gh-134786: Py_TPFLAGS_MANAGED_WEAKREF and Py_TPFLAGS_MANAGED_DICT must be used only if Py_TPFLAGS_HAVE_GC set #135863
Conversation
…hecking of it presence
|
@markshannon Please take a look. |
|
As the person who reported #134786: I would suggest making the documentation more explicit and replacing should with must here, especially since the code now errors out if |
+1 Additionally, this PR puts this into a WhatsNew entry for 3.15. This is not a new thing, this is a documentation fix + fix for the runtime to not allow these invalid types to be created. So I think the added whatsnew is misleading. |
|
I'm not sure if we should support I think the current version needs some updates and clarification in the docs. First, though, I would like to get some feedback on the overall approach. Is this the right way to do after all? Please take a look if someone interested. |
sergey-miryanov
changed the title
sergey-miryanov
changed the title
|
@markshannon Please take a look. |
| * If the :c:macro:`Py_TPFLAGS_MANAGED_DICT` and :c:macro:`Py_TPFLAGS_MANAGED_WEAKREF` | ||
| flags are set then :c:macro:`Py_TPFLAGS_HAVE_GC` must be set too. |
There was a problem hiding this comment.
| * If the :c:macro:`Py_TPFLAGS_MANAGED_DICT` and :c:macro:`Py_TPFLAGS_MANAGED_WEAKREF` | |
| flags are set then :c:macro:`Py_TPFLAGS_HAVE_GC` must be set too. | |
| * If the :c:macro:`Py_TPFLAGS_MANAGED_DICT` or :c:macro:`Py_TPFLAGS_MANAGED_WEAKREF` | |
| flag is set then :c:macro:`Py_TPFLAGS_HAVE_GC` must be set too. |
Maybe it should be "or", not "and"?
I forgot to apply changes :( |
sergey-miryanov
changed the title
According to discussion
Py_TPFLAGS_MANAGED_WEAKREFandPy_TPFLAGS_MANAGED_DICTmust be used only ifPy_TPFLAGS_HAVE_GCis set.📚 Documentation preview 📚: https://cpython-previews--135863.org.readthedocs.build/